forked from segmentio/typewriter
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tracking-plan v2 events fetch paginated #132
Merged
abhimanyubabbar
merged 7 commits into
develop
from
fix/dat-1928-v2-trackingplan-events-paginated
Feb 14, 2025
Merged
fix: tracking-plan v2 events fetch paginated #132
abhimanyubabbar
merged 7 commits into
develop
from
fix/dat-1928-v2-trackingplan-events-paginated
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jayachand
reviewed
Feb 12, 2025
Jayachand
reviewed
Feb 12, 2025
Jayachand
reviewed
Feb 12, 2025
Jayachand
reviewed
Feb 12, 2025
Jayachand
reviewed
Feb 12, 2025
akashrpo
reviewed
Feb 12, 2025
akashrpo
approved these changes
Feb 13, 2025
Jayachand
approved these changes
Feb 14, 2025
Jayachand
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank You for Contributing to RudderTyper!
We sincerely appreciate the time and effort you invest in helping to improve RudderTyper. To make the most of your contribution, we kindly ask that you document your Pull Request thoroughly.
Please note that if the information provided is insufficient, or if the Pull Request does not align with our roadmap, we may need to respectfully thank you for your effort and close the issue.
Description 📝
When fetching the trackingplan v2, we need to separately pull the events on it. By default, the system returns the events in paginated form. Therefore, we were only fetching the first 50 events on the trackingplan. This PR, allows you to recursively fetch all the events on the v2 trackingplan when pulling it from upstream API.
Respect Earns Respect 👏
We ask that you adhere to our Code of Conduct. In summary: