Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tracking-plan v2 events fetch paginated #132

Merged

Conversation

abhimanyubabbar
Copy link

Thank You for Contributing to RudderTyper!

We sincerely appreciate the time and effort you invest in helping to improve RudderTyper. To make the most of your contribution, we kindly ask that you document your Pull Request thoroughly.

Please note that if the information provided is insufficient, or if the Pull Request does not align with our roadmap, we may need to respectfully thank you for your effort and close the issue.

Description 📝

When fetching the trackingplan v2, we need to separately pull the events on it. By default, the system returns the events in paginated form. Therefore, we were only fetching the first 50 events on the trackingplan. This PR, allows you to recursively fetch all the events on the v2 trackingplan when pulling it from upstream API.

Respect Earns Respect 👏

We ask that you adhere to our Code of Conduct. In summary:

  • Use welcoming and inclusive language.
  • Respect differing viewpoints and experiences.
  • Accept constructive criticism gracefully.
  • Focus on what is best for the community.
  • Show empathy toward other community members.

@abhimanyubabbar abhimanyubabbar merged commit 0a995c1 into develop Feb 14, 2025
4 checks passed
@abhimanyubabbar abhimanyubabbar deleted the fix/dat-1928-v2-trackingplan-events-paginated branch February 14, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants