Update readme with Batch resource and rename throwaway test for provi…

…sioner
rudiv · May 17, 2024 · bc4a7fd · bc4a7fd
1 parent 30ac6c8
commit bc4a7fd
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -150,6 +150,8 @@ builder.AddAzureCosmosDBClient("cosmos",
 - [ ] (0.2.X) Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers/storedProcedures
 - [ ] (0.2.X) Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers/triggers
 - [ ] (0.2.X) Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers/userDefinedFunctions
+- [x] (0.2.5 - live) Microsoft.Batch/batchAccounts (thanks to [@WhitWaldo](https://github.com/WhitWaldo) for the contribution)
+- [x] (0.2.5 - live) Microsoft.Batch/batchAccounts/certificates (thanks to [@WhitWaldo](https://github.com/WhitWaldo) for the contribution)
 
 * Denotes that support for these resources is implemented via Azure.Provisioning.
 
@@ -253,4 +255,4 @@ else
     var id = builder.AddManagedIdentity(..);
     kv = builder.AddZtAzureKeyVault(..);
 }
-```
+```
diff --git a/tests/Achieve.Aspire.AzureProvisioning.Tests/BatchTests.cs b/tests/Achieve.Aspire.AzureProvisioning.Tests/BatchTests.cs
@@ -12,7 +12,7 @@ public class BatchTests(ITestOutputHelper output)
     public void AzureProvisionerIsAdded()
     {
         using var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish);
-        var cosmos = builder.AddAzureBatchAccount("batch", acc => { });
+        var _ = builder.AddAzureBatchAccount("batch", acc => { });
         Assert.Contains(builder.Services,
             m => m.ServiceKey != null && m.ServiceKey as Type == typeof(AzureBicepResource));
     }

diff --git a/tests/Achieve.Aspire.AzureProvisioning.Tests/CosmosDbTests.cs b/tests/Achieve.Aspire.AzureProvisioning.Tests/CosmosDbTests.cs
@@ -14,7 +14,7 @@ public class CosmosDbTests(ITestOutputHelper output)
   public void AzureProvisionerIsAdded()
   {
     using var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish);
-    var cosmos = builder.AddAzureCosmosDbNoSqlAccount("cosmos", acc => {});
+    var _ = builder.AddAzureCosmosDbNoSqlAccount("cosmos", acc => {});
     Assert.Contains(builder.Services, m => m.ServiceKey != null && m.ServiceKey as Type == typeof(AzureBicepResource));
   }
 

diff --git a/tests/Achieve.Aspire.AzureProvisioning.Tests/IdentityTests.cs b/tests/Achieve.Aspire.AzureProvisioning.Tests/IdentityTests.cs
@@ -13,7 +13,7 @@ public class IdentityTests(ITestOutputHelper output)
     public void AzureProvisionerIsAdded()
     {
         using var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish);
-        var cosmos = builder.AddManagedIdentity("testid");
+        var _ = builder.AddManagedIdentity("testid");
         Assert.Contains(builder.Services, m => m.ServiceKey != null && m.ServiceKey as Type == typeof(AzureBicepResource));
     }
 

diff --git a/tests/Achieve.Aspire.AzureProvisioning.Tests/KeyVaultTests.cs b/tests/Achieve.Aspire.AzureProvisioning.Tests/KeyVaultTests.cs
@@ -16,7 +16,7 @@ public class KeyVaultTests(ITestOutputHelper output)
     public void AzureProvisionerIsAdded()
     {
         using var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish);
-        var kv = builder.AddZtAzureKeyVault("kv", _ => { });
+        var _ = builder.AddZtAzureKeyVault("kv", _ => { });
         Assert.Contains(builder.Services, m => m.ServiceKey != null && m.ServiceKey as Type == typeof(AzureBicepResource));
     }
 

diff --git a/tests/Achieve.Aspire.AzureProvisioning.Tests/RoleAssignmentTests.cs b/tests/Achieve.Aspire.AzureProvisioning.Tests/RoleAssignmentTests.cs
@@ -15,7 +15,7 @@ public void AzureProvisionerIsAdded()
       using var builder = TestDistributedApplicationBuilder.Create(DistributedApplicationOperation.Publish);
       var id = builder.AddManagedIdentity("testid");
       var kv = builder.AddZtAzureKeyVault("kv", o => { });
-      var ra = builder.AddAzureRoleAssignment(kv, id, KeyVaultRoles.CertificateUser);
+      var _ = builder.AddAzureRoleAssignment(kv, id, KeyVaultRoles.CertificateUser);
       Assert.Contains(builder.Services, m => m.ServiceKey != null && m.ServiceKey as Type == typeof(AzureBicepResource));
     }