Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone on the Aspire team pointed me towards your project. While I've spent a little time thinking of alternatives to their approach, I read through how your project is put together and it's a much more progressed version of what I was doing, so I hope you don't mind me jumping in with some additional resources.
I thought I'd start with Batch since it's a relatively simple resource, it's something my own project has a dependency on and it's something that's probably not doing to be added to Aspire in the visible future. I also added certificates on the Batch accounts so I could try out your approach for parented resources.
Because you already had a validation method, I added a string extension to assist with naming validation and an enum extension that helps with retrieving the expected strings for some of these enums (as some of them, like
AllowedAuthenticationMode
have legacy values that wouldn't make since with the modern product names). And of course, unit tests similar to those you've already got in place.There's more that could be done here (pools, for example), but they're a bit more involved, so I just wanted to start somewhere.
Eager to jump in and contribute more resources if you're open to it, and see about helping out with some of the plumbing.