-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Ada case #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the name: Do we really want to name it "Ada case"? Do you have any reference to that name? (So we don't invent that one…) The OP named it "Pascal Snake Case", which possibly is better?
I mean it's just a coincidence this programming language uses it? or is it virtually the only case this is used haha… if so, then the name would be acceptable?
@@ -236,7 +236,7 @@ export async function init() { | |||
|
|||
// Thunderbird | |||
// Remove if part 3 of https://bugzilla.mozilla.org/show_bug.cgi?id=1630786#c4 is ever done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this bug report/commend still correct though? LIkely not as composeScripts
is now there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the comment is about declaring compose scripts in the manifest.json
file (like with content scripts), which is not yet supported by Thunderbird. (Probably should file a new bug.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should file a new bug.
Just a friendly reminder @tdulcet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did actually file a new bug a few days after that comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1902843. I updated the link in the source code in #96, which is awaiting your review.
Personally, I do not like the names "Ada case" or "Pascal snake case", so I am open to better ideas. There does not seem to by a common name for many of the coding cases, including this one. I went with "Ada case" because is used by some libraries, such as Case anything. I also already used "Upper camel case" instead of "Pascal case", so it seemed odd to then use "Pascal" for this, but both Pascal and Ada are obviously rather obscure programing languages. |
BTW no need to force-push IMHO, this just requires me to review it all over again instead of looking only at the latest commits… I don't care that much about the git history. 🙃 |
@tdulcet :
No good idea, sorry.
From what point of view are you saying that? |
I just meant that those two programing languages are comparatively less used, so many users are likely unfamiliar with them and their casing conventions. |
OK. |
typeof
operatorCC: @tDeContes