Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Ada case #94

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Added support for Ada case #94

merged 3 commits into from
Sep 11, 2024

Conversation

tdulcet
Copy link
Collaborator

@tdulcet tdulcet commented Jun 2, 2024

  • Added support for Ada case. Fixes Pascal_Snake_Case #92
  • Added support for acronyms and single letter words when splitting text for the coding cases
  • Incremented version to 0.7
  • Minor ESLint and Biome fixes
    • Removed use of the typeof operator
  • Temporally removed most references to the Unicode autocorrect feature from the AMO/ATN descriptions so we can remove the experimental label

CC: @tDeContes

@tdulcet tdulcet requested a review from rugk June 2, 2024 13:42
Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the name: Do we really want to name it "Ada case"? Do you have any reference to that name? (So we don't invent that one…) The OP named it "Pascal Snake Case", which possibly is better?

I mean it's just a coincidence this programming language uses it? or is it virtually the only case this is used haha… if so, then the name would be acceptable?

assets/texts/en/amoDescription.html Show resolved Hide resolved
assets/texts/en/atnDescription.html Outdated Show resolved Hide resolved
@@ -236,7 +236,7 @@ export async function init() {

// Thunderbird
// Remove if part 3 of https://bugzilla.mozilla.org/show_bug.cgi?id=1630786#c4 is ever done
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bug report/commend still correct though? LIkely not as composeScripts is now there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the comment is about declaring compose scripts in the manifest.json file (like with content scripts), which is not yet supported by Thunderbird. (Probably should file a new bug.)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should file a new bug.

Just a friendly reminder @tdulcet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did actually file a new bug a few days after that comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1902843. I updated the link in the source code in #96, which is awaiting your review.

@tdulcet
Copy link
Collaborator Author

tdulcet commented Jun 4, 2024

About the name: Do we really want to name it "Ada case"?

Personally, I do not like the names "Ada case" or "Pascal snake case", so I am open to better ideas. There does not seem to by a common name for many of the coding cases, including this one. I went with "Ada case" because is used by some libraries, such as Case anything. I also already used "Upper camel case" instead of "Pascal case", so it seemed odd to then use "Pascal" for this, but both Pascal and Ada are obviously rather obscure programing languages.

@rugk
Copy link
Owner

rugk commented Jun 12, 2024

BTW no need to force-push IMHO, this just requires me to review it all over again instead of looking only at the latest commits… I don't care that much about the git history. 🙃

@tdulcet tdulcet merged commit 374ed91 into main Sep 11, 2024
1 check failed
@tdulcet tdulcet deleted the ada branch September 11, 2024 10:11
@tDeContes
Copy link

@tdulcet :

About the name: Do we really want to name it "Ada case"?

Personally, I do not like the names "Ada case" or "Pascal snake case", so I am open to better ideas.

No good idea, sorry.

both Pascal and Ada are obviously rather obscure programing languages.

From what point of view are you saying that?
Ada was designed to be close to the English language (compared to common languages ​​like C).

@tdulcet
Copy link
Collaborator Author

tdulcet commented Jan 8, 2025

From what point of view are you saying that?

I just meant that those two programing languages are comparatively less used, so many users are likely unfamiliar with them and their casing conventions.

@tDeContes
Copy link

From what point of view are you saying that?

I just meant that those two programing languages are comparatively less used, so many users are likely unfamiliar with them and their casing conventions.

OK.
AFAIK, Pascal is only used for teaching.
Ada is used for teaching (thank you my teacher!) and still so far in several industries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pascal_Snake_Case
3 participants