Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore checkboxes on result type change #55

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

runarmod
Copy link
Owner

This PR fixes a couple of bugs.

  • Fixed double-creating quick select buttons (when code is reloaded)
  • Fixed checkboxes disappearing on result type change
  • Fixed abbr title to reset to "-" when no subjects are selected (instead of what the title previously was)

Closes #52

Deleted some functions which did basically the same thing. Modified `createAllCheckboxes` to reset grade-/creditCounts and update it.
@runarmod runarmod added the bug Something isn't working label Aug 21, 2024
@runarmod runarmod merged commit 0a2cdff into main Aug 22, 2024
1 check passed
@runarmod runarmod deleted the 52-restore-checkboxes-on-result-type-change branch August 22, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing between "Bare gyldige" and "Alle" removes all checkboxes
1 participant