Create ba-heal-codes #7233
Open
Create ba-heal-codes #7233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New plugin |
tylerwgrass
reviewed
Jan 14, 2025
There was a problem hiding this comment.
- Can you move this out of
render? One option would be to handle inonGameTick()instead https://github.com/evaan/ba-heal-codes/blob/c4f430e2482de6811dda376cb0c32d50d577be76/src/main/java/dev/evaan/HealCodeOverlay.java#L34-L47 - You might want to also put the code parts in something that is already iterable instead of parsing the strings every render
Some other non-blockers, but you may want to include a README to provide some example screenshots/usage/etc, as well as tags in runelite-plugin.properties to make it more discoverable
tylerwgrass
added
the
waiting for author
runelite-github-app
bot
removed
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.