Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with spaces in hubsupport search #112

Merged

Conversation

JamesJJT
Copy link
Contributor

@JamesJJT JamesJJT commented Mar 27, 2024

Fixes #110

Replacing spaces with dashes fixes #110 as the internalName from https://repo.runelite.net/plugins/manifest/${version}_full.js seems to return spaces as dashes.

Example test.

Input = plank sack

Pre fix:

image

Post fix:
image

lib/commands/hubsupport.js Outdated Show resolved Hide resolved
@JamesJJT JamesJJT requested a review from deathbeam March 28, 2024 16:52
@Nightfirecat Nightfirecat merged commit cc22f69 into runelite:master Mar 28, 2024
1 check passed
@JamesJJT JamesJJT deleted the fix-hubsupport-space-search-bug branch March 28, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/hubsupport search fails when the search term contains a space
3 participants