ERC827-like methods for ERC721Holdings #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krebernisak
approved these changes
May 4, 2018
contracts/mocks/MessageHelper.sol
Outdated
| @@ -0,0 +1,31 @@ | |||
| pragma solidity ^0.4.21; | |||
There was a problem hiding this comment.
Let's be consistent and use 'pragma solidity ^0.4.23;'
contracts/mocks/MessageHelper.sol
Outdated
| return false; | ||
| } | ||
|
|
||
| } |
|
|
||
| describe('Test Execute Calls methods', function () { | ||
| it('should allow payment through approve', async function () { | ||
| const extraData = this.message.contract.buyMessage.getData( |
There was a problem hiding this comment.
I've used encodeCall helper in r8-app tests.
It would look something like this:
const data = encodeCall('buyMessage', ['bytes32', 'uint256', 'string'], [web3.toHex(123456), 666, 'Transfer Done']);
There was a problem hiding this comment.
You are using the web3 v0.20 API and this will change with web3 v1.0 release.
There was a problem hiding this comment.
This is just a FYI comment, no need to change anything for now.
| }); | ||
| }); | ||
| }); | ||
| }; |
|
|
||
| function transferFromAndCall(address _from, uint256 _to, address _toOrigin, uint256 _tokenId, bytes _data) | ||
| public payable returns (bool); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds ERC827-like methods to ERC721Holdings to allow for value transfer with data transfer.