Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use coherent env. in release.yml #4075

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Use coherent env. in release.yml #4075

merged 2 commits into from
Jan 28, 2025

Conversation

jberthold
Copy link
Member

@jberthold jberthold commented Nov 24, 2024 •
edited
Loading

Makes release builds aware of the ghc-version to build with. (and also stack and hpack, which are minor)

@jberthold
Copy link
Member Author

https://github.com/runtimeverification/haskell-backend/actions/runs/12000042509/job/33448681602#step:5:14 shows we are currently building the ubuntu package with GHC-9.10, whereas the nix build uses GHC-9.6.5

@F-WRunTime
Copy link
Member

@jberthold no reviewers on this. Do you want it to go through? LGTM, would be good we sync the ghc between the packages nix<>ubuntu

@jberthold
Copy link
Member Author

@jberthold no reviewers on this. Do you want it to go through? LGTM, would be good we sync the ghc between the packages nix<>ubuntu

Agree, we should not build with different GHCs for master builds.
I noticed the issue but left this here to revisit later (we might want to upgrade GHC as we see it does build without problems, but I don't have time to test it properly atm).

We might as well merge this PR separately, though.

tothtamas28
tothtamas28 approved these changes Jan 28, 2025
View reviewed changes
.github/workflows/release.yml
Comment on lines +8 to +10
ghc_version: "9.6.5"
stack_version: "2.15.1"
hpack_version: '0.36'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, string literal syntax is not used consistently here.

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 4710352 into master Jan 28, 2025
6 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the Adjust-release-env branch January 28, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothtamas28 tothtamas28 tothtamas28 approved these changes

@F-WRunTime F-WRunTime Awaiting requested review from F-WRunTime

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberthold @F-WRunTime @tothtamas28