Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotating rules that preserve definedness #286

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Conversation

PetarMax
Copy link
Contributor

This PR aims to annotate all of the Kontrol rules for which we know that they preserve definedness, but the backend is not able to prove this on its own.

@PetarMax PetarMax requested a review from anvacaru January 17, 2024 11:29
@PetarMax
Copy link
Contributor Author

Related question.

@PetarMax PetarMax marked this pull request as ready for review February 25, 2024 10:51
@palinatolmach palinatolmach self-assigned this Feb 26, 2024
@palinatolmach
Copy link
Collaborator

palinatolmach commented Feb 26, 2024

The Docker test is failing in solc_to_k with

  File "/home/user/.local/lib/python3.10/site-packages/kontrol/solc_to_k.py", line 580, in __init__
    self.contract_path = self.contract_json['ast']['absolutePath']
KeyError: 'ast' 

which means that it can’t find the ast field in the compilation artifact file generated by forge build — that doesn't seem related to the changes made in the PR, I'll look into why that might be happening.

Update: it's not PR-specific, the same issue appears in other PRs and (seemingly) on different runners:

Trying to reproduce this locally now.

@rv-jenkins rv-jenkins merged commit 0251ef3 into master Feb 29, 2024
11 checks passed
@rv-jenkins rv-jenkins deleted the preserves-definedness branch February 29, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants