tests: fix version tests

runtipi · Sep 17, 2024 · 43aa667 · 43aa667
1 parent b896dc4
commit 43aa667
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/cmd/update.go b/cmd/update.go
@@ -137,7 +137,7 @@ var updateCmd = &cobra.Command{
 		// Download latest CLI
 		spinner.SetMessage("Downloading latest CLI")
 
-		downloadErr := release.DownloadLatestCLI(versionToUpdate)
+		downloadErr := release.DownloadCLI(versionToUpdate)
 
 		if downloadErr != nil {
 			spinner.Fail("Failed to download latest CLI, please copy the runtipi-cli-go.bak file to runtipi-cli-go and try again")

diff --git a/internal/release/release.go b/internal/release/release.go
@@ -86,7 +86,7 @@ func ValidateVersion(version string) (bool, error) {
 	return true, nil
 }
 
-func DownloadLatestCLI(version string) (error) {
+func DownloadCLI(version string) (error) {
 	arch := system.GetArch()
 	assetUrl := fmt.Sprintf("https://github.com/runtipi/runtipi-cli-go/releases/download/%s/runtipi-cli-go-%s", version, arch)
 

diff --git a/internal/release/release_test.go b/internal/release/release_test.go
@@ -46,7 +46,7 @@ func TestMajorValidator(t *testing.T) {
 // Test validate version
 func TestValidateVersion(t *testing.T) {
 	// Try correct version
-	validateCheckCorrect, validateCheckCorrectErr := release.ValidateVersion("v0.1.0-alpha.1-runtipi-v3.6.0")
+	validateCheckCorrect, validateCheckCorrectErr := release.ValidateVersion("v3.6.0")
 
 	// Check for errors
 	if validateCheckCorrectErr != nil {
@@ -59,7 +59,7 @@ func TestValidateVersion(t *testing.T) {
 	}
 
 	// Try wrong version
-	validateCheckWrong, validateCheckWrongErr := release.ValidateVersion("v0.1.0-alpha.1-runtipi-v3.5.8")
+	validateCheckWrong, validateCheckWrongErr := release.ValidateVersion("v3.5.8")
 
 	// Check for errors
 	if validateCheckWrongErr != nil {
@@ -88,7 +88,7 @@ func TestCLIDownload(t *testing.T) {
 	os.Remove(cliPath)
 
 	// Download new CLI
-	downloadErr := release.DownloadLatestCLI("v0.1.0-alpha.1-runtipi-v3.6.0")
+	downloadErr := release.DownloadCLI("v3.6.0")
 
 	// Check for errors
 	if downloadErr != nil {