-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #2638 Remove See more
button after the end of contributors list
#2640
base: main
Are you sure you want to change the base?
Conversation
…ntributors list Optimized: getStaticProps is Optimized
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "Fixed", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AbhiArya20, i can still see the 'See More' button
…oll functionality
I have replaced 'See More' button with infinite scroll functionality. can you please review it again PR-Demo.mp4 |
See more
button after the end of contributors listSee more
button after the end of contributors list
See more
button after the end of contributors listSee more
button after the end of contributors list
Fixes Issue
Optimizations
getStaticProps
function to improve the contributor data fetching process in parallel.Key Changes
Fetching Contributor Details:
We fetch detailed information about each contributor using the GitHub API endpoint:
https://api.github.com/users/${contributor.login}
. This is done to retrieve their full profile details, particularly the contributor's name.Name Fallback Logic:
If the API request is successful and a
name
is available, we update the contributor object with that name. If not, we fall back to using the contributor'slogin
as the name:If the request fails, we were not adding that contributor to the contributors list, but we can now fall back to
contributor.login
.