Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2638 Remove See more button after the end of contributors list #2640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AbhiArya20
Copy link

@AbhiArya20 AbhiArya20 commented Feb 9, 2025

Fixes Issue

Optimizations

  • Optimized: getStaticProps function to improve the contributor data fetching process in parallel.

Key Changes

  1. Fetching Contributor Details:
    We fetch detailed information about each contributor using the GitHub API endpoint:
    https://api.github.com/users/${contributor.login}. This is done to retrieve their full profile details, particularly the contributor's name.

  2. Name Fallback Logic:
    If the API request is successful and a name is available, we update the contributor object with that name. If not, we fall back to using the contributor's login as the name:

    { ...contributor, name: data.name || contributor.login }

    If the request fails, we were not adding that contributor to the contributors list, but we can now fall back to contributor.login.

…ntributors list

Optimized: getStaticProps is Optimized
Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 10:17pm

@github-actions github-actions bot added bug Something isn't working priority: medium Modifying an existing feature labels Feb 9, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package.json

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "Fixed", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AbhiArya20, i can still see the 'See More' button

image

@AbhiArya20
Copy link
Author

@rupali-codes,

I have replaced 'See More' button with infinite scroll functionality.

can you please review it again

PR-Demo.mp4

@AbhiArya20 AbhiArya20 changed the title Fixed: #2638 Remove See more button after the end of contributors list Fix: #2638 Remove See more button after the end of contributors list Feb 22, 2025
@AbhiArya20 AbhiArya20 changed the title Fix: #2638 Remove See more button after the end of contributors list fix: #2638 Remove See more button after the end of contributors list Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants