Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] make "master" a protected branch to enforce update via PRs only #268

Closed
mi-hol opened this issue Dec 13, 2022 · 10 comments
Closed
Assignees
Labels
IMPORTANT waiting-on-feedback blocked task, requestor or contributor needs to provide feedback wiki location & process change

Comments

@mi-hol
Copy link
Contributor

mi-hol commented Dec 13, 2022

I'd recommend to enforce certain workflows for "master" branch via "protection rules"- Possible "protection rules" such as requiring an approving review or passing status checks for all pull requests merged into the protected branch.
How to is documented in (https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule)

Background:
every member of doc-team has "merge" permission and can push to "master" branch unintentionally.

@mi-hol mi-hol added the waiting-on-feedback blocked task, requestor or contributor needs to provide feedback label Jan 2, 2023
@mi-hol
Copy link
Contributor Author

mi-hol commented Jan 3, 2023

this change links nicely with #244 & #308

@mi-hol
Copy link
Contributor Author

mi-hol commented Jan 12, 2023

Andrey is fine with recommendation provided by doc-team

@chuckwagoncomputing
Copy link
Member

I've already spoken to @mi-hol about this, but just so everyone is on the same page:
This will also mean disabling editing from https://github.com/rusefi/rusefi/wiki

@rusefillc
Copy link
Contributor

image

@rusefillc
Copy link
Contributor

even with branch protection I can still make direct commits a895791

to be honest that works for me

@rusefillc
Copy link
Contributor

I've already spoken to @mi-hol about this, but just so everyone is on the same page: This will also mean disabling editing from https://github.com/rusefi/rusefi/wiki

at the moment exactly one person can edit https://github.com/rusefi/rusefi/wiki directly and that's me

please clarify the thought process here, what are we trying to solve how?

@chuckwagoncomputing
Copy link
Member

As I understand it, the goal is to keep people from making bad commits that someone has to fix later.

Just to confirm, have you also selected "Require status checks to pass before merging"?

@rusefillc
Copy link
Contributor

I did now

image

@chuckwagoncomputing
Copy link
Member

OK Thanks.

@mi-hol
Copy link
Contributor Author

mi-hol commented Jan 15, 2023

Thank you all, from my view this is a great process improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IMPORTANT waiting-on-feedback blocked task, requestor or contributor needs to provide feedback wiki location & process change
Projects
None yet
Development

No branches or pull requests

3 participants