-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] make "master" a protected branch to enforce update via PRs only #268
Comments
Andrey is fine with recommendation provided by doc-team |
I've already spoken to @mi-hol about this, but just so everyone is on the same page: |
even with branch protection I can still make direct commits a895791 to be honest that works for me |
at the moment exactly one person can edit https://github.com/rusefi/rusefi/wiki directly and that's me please clarify the thought process here, what are we trying to solve how? |
As I understand it, the goal is to keep people from making bad commits that someone has to fix later. Just to confirm, have you also selected "Require status checks to pass before merging"? |
OK Thanks. |
Thank you all, from my view this is a great process improvement! |
I'd recommend to enforce certain workflows for "master" branch via "protection rules"- Possible "protection rules" such as requiring an approving review or passing status checks for all pull requests merged into the protected branch.
How to is documented in (https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule)
Background:
every member of doc-team has "merge" permission and can push to "master" branch unintentionally.
The text was updated successfully, but these errors were encountered: