Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for RSA 1.5 transport of AES keys #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

toshok
Copy link

@toshok toshok commented May 30, 2019

https://www.w3.org/TR/xmlenc-core/#sec-RSA-1_5

Slight departure from the spec, in that the spec reads:

Implementations must support this key transport algorithm for transporting 192-bit TRIPLEDES keys. Support of this algorithm for transporting other keys is optional.

This PR only implements AES key transport, not tripledes.

This version of the spec also has this passage:

Note: Implementation of RSA v1.5 is not recommended due to security risks associated with the algorithm.

But I want to support assertions from IDPs that aren't exactly up-to-date on the current xmlenc spec.

Fixes things for me, not sure about testing this, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant