Fix to download the correct binary for Apple silicon Macs #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mad! Thanks for the contribution mate. utACK f168d5a I don't have an OSX machine so untested. CI is going to fail with formatting errors. You can use |
|
Glad to help! I'm going to pause on merging for now, I discovered the codesign logic fails on macOS Sequoia due to invalid permissions. Will commit to this PR with a more robust solution once I find something. |
|
Couldn't reproduce the codesign failure after running on a few machines. Probably fine for now given this is how it's done in bitcoin core. I've also run |
|
Can you squash the third patch into the first one and force push please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using the (node) crate with the
from_downloaded()trait would fail on apple silicon withbad CPU type in executablePart of the update includes some code-signing, this is necessary for unsigned binaries (like bitcoind) to run on Arm Macs:
bitcoin/bitcoin#26694 (comment)