-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test that an odd capacity BufEncoder
does not compile
#157
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
#!/usr/bin/env bash | ||
# | ||
# Checks intended compile failures. | ||
|
||
set -euo pipefail | ||
|
||
REPO_DIR=$(git rev-parse --show-toplevel) | ||
|
||
compile_check() { | ||
local dir_path=$1 | ||
local expected_status=$2 | ||
local result=0 | ||
local output | ||
# All crates in the specified subdirectory must compile or fail based on expected_status | ||
for dir in "$dir_path"/*; do | ||
if [ -d "$dir" ]; then | ||
pushd "$dir" > /dev/null | ||
echo "Compiling $dir" | ||
output=$(cargo build 2>&1) | ||
if [ "$?" -ne "$expected_status" ]; then | ||
if [ "$expected_status" -eq 0 ]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why have another argument if it can be inferred from the first one and you're not comparing them anyway? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I started to change it, but it's more flexible the way it is. I'm not sure we need to but it's possible to check directories other than But if you prefer I can hard code the directory names and exit codes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Too many possibilities that we're not using are just complicating the code. Honestly, I think even having the |
||
echo "$output" | ||
echo "error: compile-tests/$dir/ failed to compile" | ||
else | ||
echo "error: compile-tests/$dir/ compiled when it should not have" | ||
fi | ||
result=1 | ||
fi | ||
popd > /dev/null | ||
fi | ||
done | ||
return "$result" | ||
} | ||
|
||
# Check that all files in compiletests pass or fail as expected | ||
cd "$REPO_DIR"/tests/compile-tests | ||
if compile_check "pass" 0 && compile_check "fail" 101; then | ||
echo "Compile tests passed" | ||
exit 0 | ||
else | ||
echo "Compile tests failed" | ||
exit 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be needed but I guess it's OK. I don't expect the output to be too large.