Prepare for initial 1.0 alpha version #162
Conversation
tcharding
force-pushed
the
02-24-release-1.0-alpha.0
branch
4 times, most recently
from
5e927dc to
18ed434
Compare
tcharding
force-pushed
the
02-24-release-1.0-alpha.0
branch
from
18ed434 to
a002401
Compare
|
I may have mentioned it already but I don't have much confidence in iterators. I remember when I tried to change something I ran into issues. Can we please only have the error types and two inherent functions? (I could also accept the trait.) |
tcharding
force-pushed
the
02-24-release-1.0-alpha.0
branch
7 times, most recently
from
ed55fbe to
aabe779
Compare
|
Moved some of the |
|
@apoelstra shall I make a |
src/iter.rs
Outdated
| @@ -194,6 +194,7 @@ where | |||
| /// Generally you shouldn't need to refer to this or bother with it and just use | |||
| /// [`HexToBytesIter::new`] consuming the returned value and use `HexSliceToBytesIter` if you need | |||
| /// to refer to the iterator in your types. | |||
| #[doc(hidden)] | |||
There was a problem hiding this comment.
Why is this hidden and not non-pub/deleted?
Yep. |
|
After sleeping on this the following thought came to me: If we are using See rust-bitcoin/rust-bitcoin#3935 for the same in |
|
@tcharding because if anybody (including us) actually uses the |
tcharding
force-pushed
the
02-24-release-1.0-alpha.0
branch
from
aabe779 to
99dae5a
Compare
We don't know what 1.0 is going to look like. For the alpha releases just remove the `examples` directory all together.
tcharding
force-pushed
the
02-24-release-1.0-alpha.0
branch
2 times, most recently
from
26574a7 to
4bbf256
Compare
We do not know exactly what 1.0 is going to look like. For now remove the `prelude` module.
In preparation for releasing a bare-bones 1.0 version of this crate add two stand alone crate level functions that decode a hex string into a vector and an array.
In preparation for releasing `v1.0` gut the crate. Delete everything not used and make anything else private except the error types and two new decoding functions.
In preparation for doing the first 1.0 alpha release set the version number, add a changelog entry, and update the lock files.
tcharding
force-pushed
the
02-24-release-1.0-alpha.0
branch
from
4bbf256 to
ef4111f
Compare
tcharding
changed the title
|
Open question: I have no idea how we will re-introduce stuff back into this from another branch and have reviewable patches? |
|
|
Any 1.0 -> 0.x should only happen by adding |
It might look a little weird in git. Normally you don't "move" code between branches like this.
But yeah, agreed. We're all pretty good at using git here and we'll figure it out. |
Oh, true, one commit deletes it another adds it. We will need to link them somehow at least. |
We would like to release a
v1.0-alphathat contains the bare minimum of code so that we can use it inprimitives.decode_vecanddecode_arrayPlease allow me to explicitly leave improving docs to be done as part of the alpha release cycles.
Close: #154