Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove nym and add storopoli as author #28

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: remove nym and add storopoli as author #28

merged 1 commit into from
May 6, 2024

Conversation

storopoli
Copy link
Contributor

@storopoli storopoli commented May 4, 2024 •
edited
Loading

I am working this weekend in a new set of PSBTs multiple inputs signing cookbook.

apoelstra
apoelstra approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fbd7f95

You might want to remove the @-mention of yourself from the PR title and commit message because it will cause you to get notifications in random obscure situations if people fork the repo.

@storopoli storopoli changed the title fix: remove nym and add @storopoli as author fix: remove nym and add storopoli as author May 4, 2024
@storopoli storopoli force-pushed the storopoli/fix-authors branch from fbd7f95 to b673e2f Compare May 4, 2024 19:03
@storopoli storopoli requested a review from apoelstra May 4, 2024 19:03
tcharding
tcharding approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b673e2f

@tcharding tcharding merged commit c3f0b1c into rust-bitcoin:master May 6, 2024
1 check passed
@storopoli storopoli deleted the storopoli/fix-authors branch May 6, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcharding tcharding tcharding approved these changes

@apoelstra apoelstra Awaiting requested review from apoelstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@storopoli @apoelstra @tcharding