Remove unnecessary methods #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We implement a bunch of traits for getting at the inner field. Also, the inner field is public. The `into_inner` and `as_inner` methods are just clutter - remove them. Don't bother doing a deprecation cycle because this change (and crate) is so trivial.
|
cc @apoelstra just flagging for transparency - I was slack here. EDIT: Typing that shamed me into doing it properly, all while you were sleeping (see #28). |
|
Yeah, if the inner field is public I think it's fine to drop these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement a bunch of traits for getting at the inner field. Also, the inner field is public. The
into_innerandas_innermethods are just clutter - remove them.Don't bother doing a deprecation cycle because this change (and crate) is so trivial.