Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CHANGELOG.md for 0.23.0 #771

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

eyusufatik
Copy link
Contributor

The mentioned commit in the changelog is this: c1bb316

Change looks unnecessary, however, I had a minor heart-attack once I saw the changelog because we've been using the global-context feature for some time.

@apoelstra
Copy link
Member

Yep, good catch!

And for what it's worth, I hate this name global-context-less-secure. The "less secure" global context is only "less secure" assuming a cascade of other failures which we have no evidence have ever happened, and assuming a physical attacker who can produce hundreds or thousands of signatures. So I apologize for your moment of panic.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4b00c71; successfully ran local tests

@apoelstra apoelstra merged commit 073e2af into rust-bitcoin:master Jan 13, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants