Partially revert #283 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
derive-revert
branch
from
ebc0e62 to
bb0bd88
Compare
|
Thanks, that appears to fix the issue. I can regenerate the PAC and there do not seem to be functional changes. |
|
cc @Emilgardis look like we should merge this and yank 0.4.10. Check of name should cover both derive cases. |
|
Sorry, I did kinda notice this when reviewing but didn't question it! |
Emilgardis
approved these changes
Feb 10, 2025
|
@robamu |
|
I suppose I could patch the vendor provided file.. Thanks for the quick fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robamu You issue may be related to #283. Try to depend on this change.