Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config subcommand #421

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Add config subcommand #421

merged 2 commits into from
Dec 4, 2023

Conversation

smoelius
Copy link
Member

@smoelius smoelius commented Nov 17, 2023

This PR adds a subcommand config to manage building AFL++. The intent is to decouple the cargo-afl installation from the Rust toolchain used to install it.

No longer will it be necessary to reinstall cargo-afl following a rustup update. Instead, the following will be possible:

cargo install cargo-afl          # Install cargo-afl and build AFL++ for the default toolchain
rustup update                    # Update the default toolchain
cargo afl config --build --force # Rebuild AFL++ for the default toolchain

Another example:

cargo +nightly install cargo-afl # Install cargo-afl and build AFL++ using the nightly toolchain
cargo afl config --build         # Build AFL++ for the default (e.g., stable) toolchain

Note that the cargo-afl installation is still tied to a particular version of AFLplusplus (currently, commit AFLplusplus/AFLplusplus@7e67dc9).

Some additional details on this PR's idea are here: AFLplusplus/AFLplusplus#1907

@smoelius smoelius force-pushed the config branch 11 times, most recently from f8ecd11 to bab7116 Compare November 18, 2023 10:19
@smoelius
Copy link
Member Author

I would love to have feedback on this idea. I'm going to leave the PR open until at least December 4, 2023 (about two weeks from now),

@smoelius smoelius mentioned this pull request Nov 19, 2023
@brunoproduit
Copy link
Contributor

Tested this yesterday and had no surprises. The cmplog example still works too 🎉

@smoelius
Copy link
Member Author

Thank you, @brunoproduit!

@smoelius smoelius merged commit a35958e into master Dec 4, 2023
12 checks passed
@smoelius smoelius deleted the config branch December 4, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants