Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFL_NO_CFG_FUZZING test added #422

Closed
wants to merge 1 commit into from
Closed

AFL_NO_CFG_FUZZING test added #422

wants to merge 1 commit into from

Conversation

HN026
Copy link

@HN026 HN026 commented Nov 18, 2023

No description provided.

@smoelius
Copy link
Member

Hi, @HN026. Thank you very much for this PR! I think a bit more work is needed before it can be considered to address #403, however.

First, it should not be necessary to modify cargo-afl itself. For example, this line adds a fuzzing feature to cargo-afl. However, fuzzing is the name of a configuration option, not a Cargo feature. Some discussion of the distinction is here.

Second, the proposed test does not actually use the AFL_NO_CFG_FUZZING environment variable. (#403 did not make this explicitly---I will update the issue.) When that environment variable is set, cargo-afl builds the target without --cfg fuzzing. So the idea is:

  • the test should invoke cargo-afl with AFL_NO_CFG_FUZZING set...
  • which should build the target without --cfg fuzzing...
  • which should enable the target to crash...
  • which should thereby demonstrate that AFL_NO_CFG_FUZZING works.

Please let me know if any of this is unclear, or if you have any questions.

@HN026
Copy link
Author

HN026 commented Nov 19, 2023

@smoelius I can't wrap around my head w the building procedure. I've written my test but cargo build and cargo afl build continuously keep failing.

@smoelius
Copy link
Member

Can you share the error message you are getting?

@HN026 HN026 closed this by deleting the head repository Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants