-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use cargo-metadata to support init command in workspace #349
Conversation
fab3eb3
to
e6c984d
Compare
e6c984d
to
076c771
Compare
I've had issues with |
Using hyperfine on my M1, it adds ~1s Feature branch:
Main branch:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One second doesn't seem too bad, given that this fixes bugs and cleans up some fiddly bits.
Some questions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like CI is failing? Don't have time to dig in myself at the moment. |
The tests were relying on the panic error format pre rustc 1.73.0 https://blog.rust-lang.org/2023/10/05/Rust-1.73.0.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
closes #333
Instead of manually parsing the toml file and failing in workspace members, the package name and edition are obtained via cargo-metadata (this also seems to obviate the need to pass that path which is a breaking change to a public API). The way the tests are setup was making cargo-metadata think that each test is a member of cargo-fuzz so I added an empty
workspace
entry to the tests' Cargo.toml.