add llvm-path option #354
Merged
add llvm-path option #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows the usage of an already installed llvm-profdata binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the usage of an already installed
llvm-profdatabinary.If the user does not provide an
llvm-pathcargo-fuzz will try to use the one installed throughrustup component add llvm-tools-preview.If that fails the same instructions to install
llvm-tools-previewas before as shown.The name of the option and the fact that a user should set it to the bin folder of an LLVM installation (not to the binary itself) follows the same convention as
grcov.Closes #353
Let me know if something needs to change, or if there's a reason why we should avoid allowing the user to set its own
llvm-profdata