Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported architectures in README.md #377

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

Shnatsel
Copy link
Member

In my tests fuzzing worked perfectly fine on Aarch64 Linux.

Sancov does not document the list of supported platforms, so list the platforms supported by Rust ASAN, which we enable by default.

In my tests fuzzing worked perfectly fine on Aarch64 Linux.

Sancov [does not document](https://clang.llvm.org/docs/SanitizerCoverage.html) the list of supported platforms, so list the platforms supported by [Rust ASAN](https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#addresssanitizer), which we enable by default.
@Shnatsel Shnatsel merged commit 2100d6d into main Jul 12, 2024
2 checks passed
@Shnatsel Shnatsel deleted the clarify-architectures branch July 12, 2024 21:37
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we still do reviews, even for small-ish PRs, on this repo?

$ cargo install -f cargo-fuzz
```
Note: `libFuzzer` needs LLVM sanitizer support, so this only works on x86-64 and Aarch64,
and only on Unix-lile operating systems (not Windows). You'll also need a C++ compiler with C++11 support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and only on Unix-lile operating systems (not Windows). You'll also need a C++ compiler with C++11 support.
and only on Unix-like operating systems (not Windows). You'll also need a C++ compiler with C++11 support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. Thanks for the quick review!

@Shnatsel Shnatsel restored the clarify-architectures branch July 12, 2024 22:19
@Shnatsel Shnatsel deleted the clarify-architectures branch July 12, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants