Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Itertools::owned() / Owned. #1015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hadronized
Copy link

This is very similar to std’s Iterator::clone() / Cloned, but works on more types, such as CStr / CString.

This is very similar to std’s `Iterator::clone()` / `Cloned`, but works on more
types, such as `CStr` / `CString`.
@phimuemue
Copy link
Member

Is this essentially iterator.map(ToOwned.to_owned)?

If so:

  • We are reluctant to include even more "special-case map instances" (relevant discussion e.g. Add map_err and err_into iterator adapters #714 (comment)). I support these arguments and would prefer to not pull it into Itertools.
  • If someone else wants to merge, it should probably be implemented in terms of MapSpecialCase.

@hadronized
Copy link
Author

Understood, I’ll wait for others to comment to decide what to do but I’m fine to close if you think it’s not a good fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants