-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product_ok
and sum_ok
#814
Open
sjackman
wants to merge
1
commit into
rust-itertools:master
Choose a base branch
from
sjackman:sj/try_sum
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this is an inelegantly large number of generic arguments.
This is a fairly radical alternative, but: What if we just mirrored the stdlib
Try
trait? We can pub-in-priv ourTry
-fork so that folks don't end up explicitly depending on it, and then simply (and potentially non-breaking-ly!) switch over to the standard libraryTry
once it's stabilized.If we do this, our
*_ok
functions will support more than justResult
s, and they'll be able to take just one generic argument, rather than three (I think).Thoughts, @Philippe-Cholet and @phimuemue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=7b632d50ccce769af18ec8985ff45359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sure is radical but interesting, maybe it should have its own issue.
About the names,
*_ok
now andtry_*
later? (ormaybe_*
?!)After a quick look,
ControlFlow
requires 1.55+ while we currently have 1.43. Unless we copy it too?I previously read something about
#[track_caller]
but don't remember much about its use.In libcore,
fold
is usually specialized usingtry_fold
specializations alongside withNeverShortCircuit
which surely won't be public forever so I thought that we would copy it at some point.