Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools version of containers #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Christiaan676
Copy link

Adds a tools version of the containers, that adds the following rust components: rustfmt, clippy and llvm-tools-preview. More rust components could be added. But this seams to me the most applicable set for CI.

Al lot of firsts in this pull-request so let me know if I need to change something.

Solves issue: #97

@Trolldemorted
Copy link

@sfackler @Muscraft @sksat could you accept or refuse this PR, or is this repository abandonware except for the version bumps?

@Muscraft
Copy link
Member

I'm sorry that I won't be able to help as I'm not a maintainer of this repository, so I have no ability to accept or reject this PR.

That being said saying "or is this repository abandonware except for the version bumps" is both incorrect (there have been PRs that add things) and it can be off-putting to maintainers, hurting your cause. We have no idea what is going on in their day to day lives, or how much time they have to commit to maintaining this repository. I understand it can be frustrating for a PR to be open for a long time with no decision on what to do with it. A better way to handle this situation is to ask politely for a review and if you feel up to it, give more context for why the PR is wanted in the first place.

@sksat
Copy link
Contributor

sksat commented Oct 18, 2023

I'm also not a maintainer of this repository.

Personally, this feature is my wish too, but I strongly agree with Muscraft that a polite request should be made.
In general, accumulating messy mentions that lack background makes maintainers less and less willing to respond to notifications......

@@ -0,0 +1,3 @@
FROM rust:%%RUST-IMAGE%%

RUN rustup component add rustfmt clippy llvm-tools-preview
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Christiaan676 I think this is now available as llvm-tools directly without the preview

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed seems to be the case. (https://rust-lang.github.io/rustup/concepts/components.html).

This merge request is already more than a year old. I'm willing to update it and change things if needed, but only if a maintainer is wiling to review and eventually merge it. Currently updating it seems to be a wast of my time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants