Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alternative QNX Neutrino network stack io-sock #4169

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

flba-eb
Copy link
Contributor

@flba-eb flba-eb commented Dec 2, 2024

Description

QNX 7.1 supports two network stacks:

  1. io-pkt, which is default
  2. io-sock, which is optional and should be default in QNX 8.0

As one can see in the io-sock migration notes, this changes the libc API in a way similar to e.g. linux-gnu vs. linux-musl.

This change uses a new target which has a different value for target_env, so that e.g. libc can distinguish between both APIs. New target pull request for rustc: rust-lang/rust#133631

CC: @jonathanpallant @japaric @gh-tr @AkhilTThomas

Sources

  • Relevant tests in libc-test/semver have been updated
    ⚠️ QNX is unfortunately not ABI compatible between versions, hence semver checks are not possible.
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@flba-eb flba-eb force-pushed the add_iosock_1.0 branch 4 times, most recently from b9d6917 to 3f75bbc Compare December 3, 2024 09:44
@flba-eb flba-eb marked this pull request as ready for review December 11, 2024 08:21
@flba-eb flba-eb marked this pull request as draft December 11, 2024 08:22
@bors
Copy link
Contributor

bors commented Dec 17, 2024

☔ The latest upstream changes (presumably #4198) made this pull request unmergeable. Please resolve the merge conflicts.

@flba-eb flba-eb force-pushed the add_iosock_1.0 branch 3 times, most recently from 273da82 to 2410b84 Compare December 18, 2024 08:48
@bors
Copy link
Contributor

bors commented Dec 19, 2024

☔ The latest upstream changes (presumably #4202) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants