Classify FIXMEs - 3 #4231
Classify FIXMEs - 3 #4231
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
lvllvl
force-pushed
the
4117-part-3
branch
3 times, most recently
from
f5f94f1 to
d545f78
Compare
# This is the 1st commit message: chore: add labels to FIXMEs # This is the commit message rust-lang#2: chore: add labels to FIXMEs # This is the commit message rust-lang#3: Declare `setdomainname` and `getdomainname` on Android. Android [supports] `setdomainname` and `getdomainname` in API level 26. [supports] https://github.com/aosp-google/bionic/blob/28f9101d76b709febe25977f98530d77580387d1/libc/include/unistd.h#L236 # This is the commit message rust-lang#4: Move `setdomainname` and `getdomainname` into linux_like.
tgross35
added
the
stable-nominated
There was a problem hiding this comment.
Most look good, just a couple suggested adjustments. However, it looks like you may have picked up some unrelated changes? Probably happened with a squash, the commit says:
This is a combination of 4 commits.
[...]
# This is the commit message #3:
Declare `setdomainname` and `getdomainname` on Android.
Android [supports] `setdomainname` and `getdomainname` in API level 26.
[supports] https://github.com/aosp-google/bionic/blob/28f9101d76b709febe25977f98530d77580387d1/libc/include/unistd.h#L236
# This is the commit message #4:
Move `setdomainname` and `getdomainname` into linux_like.
| @@ -308,7 +308,7 @@ s_no_extra_traits! { | |||
| pub uc_mcontext: mcontext_t, | |||
| pub uc_sigmask: crate::sigset_t, | |||
| __private: [u8; 512], | |||
| // FIXME: the shadow stack field requires glibc >= 2.28. | |||
| // FIXME(linux): the shadow stack field requires glibc >= 2.28. | |||
There was a problem hiding this comment.
Probably FIXME(glibc) here
| @@ -286,7 +286,7 @@ pub const SYS_clock_settime: c_int = 112; | |||
| pub const SYS_clone: c_int = 220; | |||
| pub const SYS_close: c_int = 57; | |||
| pub const SYS_connect: c_int = 203; | |||
| pub const SYS_copy_file_range: c_int = -1; // FIXME | |||
| pub const SYS_copy_file_range: c_int = -1; // FIXME(musl) | |||
There was a problem hiding this comment.
I don't know if there is something musl-specific here, probably FIXME(hexagon) in this file
Description
Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI