Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the naked function attribute #1153

Closed
wants to merge 2 commits into from

Conversation

bstrie
Copy link
Contributor

@bstrie bstrie commented Feb 1, 2022

This PR updates the reference to fulfill the documentation requirement of the stabilization checklist for RFC 2972, tracked at rust-lang/rust#90957 .

@ehuss ehuss added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Feb 1, 2022
@SimonSapin
Copy link

Is this a draft because rust-lang/rust#93587 should be merged first, or are there some other changes still needed?

@traviscross
Copy link
Contributor

In discussing this today on the lang-docs call, we note the recent activity on these attributes:

This was FCPed a long time ago here:

...but should be looked at again by lang before we actually stabilize this.

cc @folkertdev

@folkertdev folkertdev mentioned this pull request Dec 1, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2024

☔ The latest upstream changes (possibly bf115a4) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Dec 3, 2024
@tgross35
Copy link
Contributor

This should be superseded by #1689.

@traviscross
Copy link
Contributor

Thanks. Closing in favor of:

@tgross35
Copy link
Contributor

On a related note note @bstrie since you were very involved with the original stabilization of constrained naked functions, you may want to take a look at the new stabilization proposal at rust-lang/rust#134213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants