Doc: Add the LoongArch stabilized target features #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
heiher
force-pushed
the
loong-target-features
branch
from
bc1984d to
f07ba46
Compare
ehuss
added
the
S-waiting-on-stabilization
ehuss
reviewed
Jan 9, 2025
Comment on lines
+243
to
+244
| [LoongArch Reference Manual]: https://github.com/loongson/LoongArch-Documentation | ||
| [LoongArch GitHub Account]: https://github.com/loongson |
There was a problem hiding this comment.
Is there documentation that is more alive than these links? The documentation link looks like it is archived, and I don't know what else I would look at on the GitHub account. Is there a new location where the documentation lives? Is there a way to deep-link to the individual features (like wasm does)?
| `frecipe` | | FRECIPE --- Reciprocal approximation instrutions | ||
| `lasx` | `lsx` | LASX --- 256-bit vector instructions | ||
| `lbt` | | LBT --- Binary translation instructions | ||
| `lsx` | `d` | LSX --- 128-bit vector instructions |
There was a problem hiding this comment.
This mentions d as an implicitly enabled feature, but I don't see that as a feature that exists.
ehuss
added
S-waiting-on-author
|
☔ The latest upstream changes (possibly f80986b) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the stabilized target features as part of rust-lang/rust#135015.