Remove emsdk version update from 1.84.0 relnotes #135266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
I suppose we needed a libc 0.2.170 release which hasn't happened yet. |
|
and a backport. sigh. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 12, 2025
…mulacrum Remove emsdk version update from 1.84.0 relnotes See [this comment](rust-lang#131467 (comment)). The reproducer in that comment does indeed show that rustup's `rust-std` component is still compiled with the old emscripten ABI because libc's config flag `emscripten_new_stat_abi` is not set. rust-lang#131533 presumably had no effect because the wrong CI file was modified. So nothing has changed since 1.83.0. The PR author (workingjubilee) is currently on vacation. Also the issue rust-lang#131467 should be reopened.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#132232 (CI: build FreeBSD artifacts on FreeBSD 13.4) - rust-lang#135266 (Remove emsdk version update from 1.84.0 relnotes) - rust-lang#135364 (Cleanup `suggest_binding_for_closure_capture_self` diag in borrowck) - rust-lang#135375 (allow rustdoc-js tests to be run at stage0) - rust-lang#135379 (Make (unstable API) `UniqueRc` invariant for soundness) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135266 (Remove emsdk version update from 1.84.0 relnotes) - rust-lang#135364 (Cleanup `suggest_binding_for_closure_capture_self` diag in borrowck) - rust-lang#135375 (allow rustdoc-js tests to be run at stage0) - rust-lang#135379 (Make (unstable API) `UniqueRc` invariant for soundness) - rust-lang#135389 (compiletest: include stage0-sysroot libstd dylib in recipe dylib search path) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2025
Rollup merge of rust-lang#135266 - kadiwa4:no_emsdk_update, r=Mark-Simulacrum Remove emsdk version update from 1.84.0 relnotes See [this comment](rust-lang#131467 (comment)). The reproducer in that comment does indeed show that rustup's `rust-std` component is still compiled with the old emscripten ABI because libc's config flag `emscripten_new_stat_abi` is not set. rust-lang#131533 presumably had no effect because the wrong CI file was modified. So nothing has changed since 1.83.0. The PR author (workingjubilee) is currently on vacation. Also the issue rust-lang#131467 should be reopened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment. The reproducer in that comment does indeed show that rustup's
rust-stdcomponent is still compiled with the old emscripten ABI because libc's config flagemscripten_new_stat_abiis not set.#131533 presumably had no effect because the wrong CI file was modified. So nothing has changed since 1.83.0. The PR author (workingjubilee) is currently on vacation.
Also the issue #131467 should be reopened.