Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FnKind variant to hold &Fn #136164

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

celinval
Copy link
Contributor

Pulling the change suggested in #128045 to reduce the impact of changing Fn item.

r? @oli-obk

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 28, 2025
@rust-log-analyzer

This comment has been minimized.

@celinval celinval marked this pull request as draft January 28, 2025 01:52
compiler/rustc_ast/src/mut_visit.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/mut_visit.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/visit.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
@celinval
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2025
@celinval celinval marked this pull request as ready for review January 28, 2025 19:29
@oli-obk
Copy link
Contributor

oli-obk commented Jan 28, 2025

Thanks! Lots of improvements that I didn't expect

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 28, 2025

📌 Commit c22a271 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#135625 ([cfg_match] Document the use of expressions.)
 - rust-lang#135902 (Do not consider child bound assumptions for rigid alias)
 - rust-lang#135943 (Rename `Piece::String` to `Piece::Lit`)
 - rust-lang#136104 (Add mermaid graphs of NLL regions and SCCs to polonius MIR dump)
 - rust-lang#136143 (Update books)
 - rust-lang#136147 (ABI-required target features: warn when they are missing in base CPU)
 - rust-lang#136164 (Refactor FnKind variant to hold &Fn)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2839307 into rust-lang:master Jan 29, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 29, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
Rollup merge of rust-lang#136164 - celinval:chores-fnkind, r=oli-obk

Refactor FnKind variant to hold &Fn

Pulling the change suggested in rust-lang#128045 to reduce the impact of changing `Fn` item.

r? `@oli-obk`
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 6, 2025
Refactor FnKind variant to hold &Fn

Pulling the change suggested in rust-lang#128045 to reduce the impact of changing `Fn` item.

r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants