update rewrite_chain to return RewriteResult #6270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
ytmimi
reviewed
Aug 7, 2024
ding-young
commented
Aug 8, 2024
ytmimi
reviewed
Aug 8, 2024
ytmimi
reviewed
Aug 8, 2024
ding-young
commented
Aug 14, 2024
ding-young
commented
Aug 15, 2024
Comment on lines
+100
to
+105
| // TODO(ding-young): Consider calling format_overflow_style() | ||
| // only when item.rewrite_result() returns RewriteError::ExceedsMaxWidth. | ||
| // It may be inappropriate to call format_overflow_style on other RewriteError | ||
| // since the current approach retries formatting if allow_overflow is true | ||
| item.rewrite_result(context, rewrite_shape) | ||
| .or_else(|_| format_overflow_style(item.span, context).unknown_error()) |
There was a problem hiding this comment.
I updated the TODO comment to include the detail about the future improvement.
ding-young
commented
Aug 15, 2024
Comment on lines
81
to
85
| fn format_overflow_style(span: Span, context: &RewriteContext<'_>) -> Option<String> { | ||
| // TODO(ding-young): Currently returning None when the given span is out of the range | ||
| // covered by the snippet provider. If this is a common cause for internal | ||
| // rewrite failure, add a new enum variant and return RewriteError instead of None | ||
| context.snippet_provider.span_to_snippet(span).map(|s| { |
ytmimi
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks for making those updates.
Edit: Diff Check Job passed ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by #6206
Description
rewrite_resultforChainrewrite_chainand methods of the traitChainFormatterto return RewriteResultTODO
I'll add some comments to the code shortly