Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl rewrite_result for ForeignItem, TraitAliasBounds, WherePredicate #6309

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Impl rewrite_result for ForeignItem, TraitAliasBounds, WherePredicate #6309

merged 2 commits into from
Sep 5, 2024

Conversation

ding-young
Copy link
Contributor

@ding-young ding-young commented Sep 1, 2024 •
edited
Loading

Tracked by #6206

@ding-young ding-young mentioned this pull request Sep 1, 2024
Open
41 tasks
@ytmimi ytmimi mentioned this pull request Sep 1, 2024
Merged
@ytmimi ytmimi added the GSoC Google Summer of Code label Sep 3, 2024
ytmimi
ytmimi approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here look good to me 👍🏼

Nice catch making compute_budgets_for_params infallible.

@ytmimi
Copy link
Contributor

ytmimi commented Sep 5, 2024 •
edited
Loading

Running the Diff Check

Edit: Job passed ✅

@ytmimi ytmimi merged commit b40c3cc into rust-lang:master Sep 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
GSoC Google Summer of Code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ding-young @ytmimi @rustbot