Skip to content

Commit

Permalink
Improve mvn.
Browse files Browse the repository at this point in the history
  • Loading branch information
dvc94ch committed Oct 23, 2022
1 parent 995d209 commit 27e9490
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 13 deletions.
1 change: 1 addition & 0 deletions mvn/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ log = "0.4.17"
pubgrub = "0.2.1"
quick-xml = { version = "0.25.0", features = ["serialize"] }
serde = { version = "1.0.145", features = ["derive"] }
xcommon = { path = "../xcommon" }
36 changes: 23 additions & 13 deletions mvn/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
use crate::metadata::Metadata;
use crate::package::Artifact;
use crate::pom::Pom;
use crate::pom::{Pom, Dependency};
use anyhow::Result;
use pubgrub::error::PubGrubError;
use pubgrub::range::Range;
use pubgrub::report::{DefaultStringReporter, Reporter};
use pubgrub::solver::{Dependencies, DependencyProvider};
use std::borrow::Borrow;
use std::collections::HashMap;
use std::error::Error;
use std::path::{Path, PathBuf};
use std::str::FromStr;
Expand All @@ -26,6 +27,7 @@ pub struct Maven<D: Download> {
client: D,
cache_dir: PathBuf,
repositories: Vec<&'static str>,
local: HashMap<(Package, Version), Dependencies<Package, Version>>,
}

impl<D: Download> Maven<D> {
Expand All @@ -35,13 +37,22 @@ impl<D: Download> Maven<D> {
cache_dir,
client,
repositories: vec![],
local: Default::default(),
})
}

pub fn add_repository(&mut self, repo: &'static str) {
self.repositories.push(repo);
}

pub fn add_package(&mut self, package: Package, version: Version, deps: Vec<Dependency>) {
let deps = deps
.into_iter()
.map(|dep| (dep.package(), dep.range().unwrap()))
.collect();
self.local.insert((package, version), Dependencies::Known(deps));
}

pub fn resolve(&self, package: Package, version: Version) -> Result<Vec<PathBuf>> {
Ok(pubgrub::solver::resolve(self, package, version)
.map_err(|err| {
Expand Down Expand Up @@ -90,18 +101,7 @@ impl<D: Download> Maven<D> {
.versions()
.iter()
.filter_map(|version| Version::from_str(version).ok())
.filter(|version| {
if let Some(suffix) = version.suffix.as_ref() {
if suffix.starts_with("alpha")
|| suffix.starts_with("beta")
|| suffix.starts_with("RC")
|| suffix.starts_with('M')
{
return false;
}
}
true
})
.filter(|version| version.suffix.is_none())
.filter(|version| range.contains(version))
.rev()
.collect(),
Expand Down Expand Up @@ -160,6 +160,13 @@ impl<D: Download> Maven<D> {
}
anyhow::ensure!(downloaded, "artifact not found {} {}", artifact, ext);
}
if ext == "aar" {
let jar = self.cache_dir.join(artifact.file_name("jar"));
if !jar.exists() {
let classes = xcommon::extract_zip_file(&path, "classes.jar")?;
std::fs::write(jar, classes)?;
}
}
Ok(path)
}
}
Expand Down Expand Up @@ -194,6 +201,9 @@ impl<D: Download> DependencyProvider<Package, Version> for Maven<D> {
package: &Package,
version: &Version,
) -> Result<Dependencies<Package, Version>, Box<dyn Error>> {
if let Some(deps) = self.local.get(&(package.clone(), version.clone())) {
return Ok(deps.clone());
}
//println!("get dependencies {} {}", package, version);
let pom = self.pom(Artifact { package, version }).unwrap();
let deps = pom
Expand Down
20 changes: 20 additions & 0 deletions mvn/src/pom.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use crate::package::{Package, Version};
use anyhow::Result;
use pubgrub::range::Range;
use serde::{Deserialize, Serialize};
use std::str::FromStr;

#[derive(Default, Deserialize, Serialize)]
#[serde(rename = "project")]
Expand Down Expand Up @@ -63,6 +64,25 @@ impl Dependency {
}
}

impl FromStr for Dependency {
type Err = anyhow::Error;

fn from_str(dep: &str) -> Result<Self> {
let (group, rest) = dep
.split_once(':')
.ok_or_else(|| anyhow::anyhow!("invalid dep"))?;
let (name, version) = rest
.split_once(':')
.ok_or_else(|| anyhow::anyhow!("invalid dep"))?;
Ok(Self {
group: group.into(),
name: name.into(),
version: version.into(),
scope: None,
})
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down

0 comments on commit 27e9490

Please sign in to comment.