nostr: add NIP-35 support #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1wErt3r
force-pushed
the
nip-35
branch
2 times, most recently
from
83ec494 to
b22d0a3
Compare
- Added `Torrent` and `TorrentFile` structs to represent torrent metadata and files.
- Implemented `to_event_builder` method for `Torrent` to convert metadata into a Nostr event.
- Added `TorrentComment` struct to represent comments on torrent events.
- Implemented `to_event_builder` method for `TorrentComment` to convert comments into a Nostr event.
```rust
use nostr::nips::nip35::{Torrent, TorrentFile, TorrentComment};
use nostr::{EventBuilder, EventId, RelayUrl};
// Create a Torrent instance
let torrent = Torrent {
title: "Example Torrent".to_string(),
description: "This is an example torrent.".to_string(),
info_hash: "abcdef1234567890".to_string(),
files: vec![
TorrentFile {
name: "file1.txt".to_string(),
size: 1024,
},
TorrentFile {
name: "file2.txt".to_string(),
size: 2048,
},
],
trackers: vec!["http://tracker.example.com".to_string()],
categories: vec!["video".to_string(), "movie".to_string()],
hashtags: vec!["example".to_string()],
};
// Convert to Nostr event
let event_builder = torrent.to_event_builder();
// Create a TorrentComment instance
let comment = TorrentComment {
torrent_event: EventId::new(),
content: "This is a comment.".to_string(),
relay_url: Some(RelayUrl::new("http://relay.example.com")),
};
```
This commit adds support for sharing BitTorrent metadata and comments through Nostr events, as specified in [NIP-35](https://github.com/nostr-protocol/nips/blob/master/35.md).
yukibtc
requested changes
Dec 20, 2024
|
In the review I missed a thing. Can you add this like to the pub use crate::nips::nip35::{self, *}; |
|
Thanks! During the cherry-picking I've fixed some missing thing and the torrent event building (the tags were wrong but I didn't noticed in the last review). Cherry-picked and squashed at af36bba |
|
Thank you for taking the time to do such a thorough review! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for NIP35 (BitTorrent metadata)
TorrentandTorrentFilestructs to represent torrent metadata and files.to_event_buildermethod forTorrentto convert metadata into a Nostr event.TorrentCommentstruct to represent comments on torrent events.to_event_buildermethod forTorrentCommentto convert comments into a Nostr event.This commit adds support for sharing BitTorrent metadata and comments through Nostr events, as specified in NIP-35.