Add apt dependencies for xen-sys CI tests #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If --load is not provided to "docker build" command, the image only remains in the local cache and is not available for use locally when doing "docker run rustvmm/dev:$VERSION" like the README suggests. Without this change using the image locally is not possible, the image does not show up when doing `docker image ls` and the tag is not found when doing `docker run <TAG>`. the `docker build` step prints this warning: "WARNING: No output specified with docker-container driver. Build result will only remain in the build cache." Signed-off-by: Manos Pitsidianakis <[email protected]>
epilys
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat,
ShadowCurse and
TimePrinciple
as code owners
roypat
approved these changes
Jan 14, 2025
Install podman in order to be able to build and run containers inside the CI container, and install binutils-aarch64-linux-gnu since the aarch64-linux-gnu-objcopy binary is required to be able to create aarch64 kernel ELFs for testing. Signed-off-by: Manos Pitsidianakis <[email protected]>
epilys
force-pushed
the
add-podman-for-xen-sys
branch
from
346e03b to
a6859cd
Compare
stefano-garzarella
approved these changes
Jan 15, 2025
stsquad
approved these changes
Jan 15, 2025
|
CI has completed successfully, this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install podman in order to be able to build and run containers inside
the CI container, and install binutils-aarch64-linux-gnu since the
aarch64-linux-gnu-objcopy binary is required to be able to create
aarch64 kernel ELFs for testing.
Signed-off-by: Manos Pitsidianakis [email protected]