Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump vm-memory and vmm-sys-util #30

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

likebreath
Copy link
Collaborator

@likebreath likebreath commented Jan 17, 2024

Summary of the PR

Bump to vm-memory v0.14.0 and vmm-sys-util v0.12.1.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

This patch is for fixing the following errors:

   --> src/lib.rs:359:9
    |
358 |           let mut server_version_data = Vec::new();
    |                                         ---------- help: consider replacing this with: `vec![0; server_version.header.message_size as usize - size_of::<Version>()]`
359 | /         server_version_data.resize(
360 | |             server_version.header.message_size as usize - size_of::<Version>(),
361 | |             0,
362 | |         );
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization
    = note: `-D clippy::slow-vector-initialization` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::slow_vector_initialization)]`

Signed-off-by: Bo Chen <[email protected]>
@rbradford rbradford merged commit a1f6e52 into rust-vmm:main Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants