Add support for vhost device input v1 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo-Yan
requested review from
stsquad,
vireshk,
stefano-garzarella and
epilys
as code owners
Ablu
reviewed
Nov 30, 2023
epilys
reviewed
Nov 30, 2023
Leo-Yan
force-pushed
the
add_spport_vhost_device_input_v1
branch
3 times, most recently
from
ea09275 to
6d8fc1a
Compare
Ablu
reviewed
Dec 4, 2023
|
|
||
| for handle in handles { | ||
| handle.join().map_err(|_| Error::FailedJoiningThreads)??; | ||
| } |
There was a problem hiding this comment.
Sorry, when reconsidering the suggestion to use a thread::scope was not super great here... You would still need to manually .join() in order to report the error properly. That said, I am a bit confused about the error that you ran into...
But lets just keep the code as you had it initially. We probably need some helper to terminate threads as soon any thread fails... But that is out of scope for this PR of course.
epilys
changed the title
epilys
reviewed
Dec 4, 2023
Leo-Yan
force-pushed
the
add_spport_vhost_device_input_v1
branch
4 times, most recently
from
2848be7 to
6d6390c
Compare
epilys
previously approved these changes
Dec 5, 2023
Ablu
approved these changes
Dec 6, 2023
Leo-Yan
force-pushed
the
add_spport_vhost_device_input_v1
branch
from
6d6390c to
50a6d17
Compare
|
https://github.com/rust-vmm/vm-memory/pull/274/files will hopefully allow us to get rid of Default trait impl in the future. |
epilys
previously approved these changes
Dec 7, 2023
epilys
force-pushed
the
add_spport_vhost_device_input_v1
branch
from
50a6d17 to
3d2d27d
Compare
vireshk
reviewed
Dec 7, 2023
added 2 commits
December 7, 2023 19:08
This patch is to add support for vhost input device emulation. The code skeleton heavily reuses vhost-device-i2c and vhost-device-rng, including sharing the same license, and how to create the multi-thread mode and daemon for backend virtual device. It gives detailed usage for enabling virtual input device for guest in the README.md. Signed-off-by: Leo Yan <[email protected]>
This patch adds test cases for verification vhost input backend. Signed-off-by: Leo Yan <[email protected]>
auto-merge was automatically disabled
December 7, 2023 11:27
Head branch was pushed to by a user without write access
Leo-Yan
force-pushed
the
add_spport_vhost_device_input_v1
branch
from
3d2d27d to
c271be6
Compare
epilys
approved these changes
Dec 7, 2023
stsquad
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This patch set is to add vhost backend for emulation input device.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.