Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector_id to DrmWindowHandle #170

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add connector_id to DrmWindowHandle #170

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b598cf5
Add connector_id to DrmDisplayHandle
morr0ne Jul 4, 2024
332ee85
Fix DrmDisplayHandle::new doc-test
morr0ne Jul 5, 2024
2c43a16
Move connector_id to DrmWindowHandle
morr0ne Jul 5, 2024
017263b
Add doc comment for connector_id
morr0ne Jul 5, 2024
1eb46ad
Update changelog
morr0ne Jul 5, 2024
e51370e
Add new_with_connector_id constructor to DrmWindowHandle
morr0ne Jul 13, 2024
10eb23b
Fix type in new_with_connector_id doctest
morr0ne Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/unix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ impl DrmDisplayHandle {
pub struct DrmWindowHandle {
/// The primary drm plane handle.
pub plane: u32,
pub connector_id: Option<NonZeroU32>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should document what is it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ideally with links to other documentation explaining it, if such docs exist.

}

impl DrmWindowHandle {
Expand All @@ -255,7 +256,10 @@ impl DrmWindowHandle {
/// let handle = DrmWindowHandle::new(plane);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this example to also set the connector_id

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean here is something like:

Suggested change
/// let handle = DrmWindowHandle::new(plane);
/// # connector_id = unsafe { NonZeroU32::new_unchecked(1) };
/// let mut handle = DrmWindowHandle::new(plane);
/// handle.connector_id = Some(connector_id);

/// ```
pub fn new(plane: u32) -> Self {
Self { plane }
Self {
plane,
connector_id: None,
}
}
}

Expand Down
Loading