-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taskbar progress #3241
base: master
Are you sure you want to change the base?
Taskbar progress #3241
Conversation
Dropping some stuff I found while searching for cross-platform compatibility:
|
Ah didn't know that this is not only a Windows thing, will look into it |
Let's do it in follow-ups though, because this here is uncontroversial while the others are not. |
Such stuff generally has nothing to do with windowing which is all winit about. That's the reason external APIs exist. On Linux there's no standard interface for that, the same goes to tray. It's usually all dbus, because again, nothing to do with windowing and tied to specific DE, so not winit job. |
Agreed with @kchibisov. If it has nothing to do with windowing, it doesn't belong in |
I mean there is already a function to hide the window in the taskbar, and I agree that the taskbar and tray area are not really window related. But the necessary groundwork is already there and setting the progress requires the hwnd, and having the functionality in winit makes it also more visible to the user. It's also relatively light-weight, easy to maintain, and common. But I would never add other taskbar functionalities though like adding buttons, etc. |
Just out of curiosity, the taskbar buttons have to be handled in WndProc https://github.com/microsoft/Windows-classic-samples/blob/main/Samples/Win7Samples/winui/shell/appshellintegration/TaskbarThumbnailToolbar/ThumbnailToolbar.cpp |
I assume this was meant for Linux only? Windows still seems in scope to me considering we are handling plenty of similar taskbar related things there already. I would consider MacOS not in scope as well because it doesn't actually offer an API to do that. |
CHANGELOG.md
if knowledge of this change could be valuable to usersThis adds a simple way to set the progress indicator in the taskbar on Windows, there is still no way to set the state to error or paused, and don't know if it should be added.