On Windows, improve the performance for high polling rate mouse. #3609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a high polling rate mouse on Windows, fast mouse motions result in numerous
WM_NCHITTEST
messages being generated.Processing each of these messages vialeads to noticeable frame rate drops across various applications (bevyengine/bevy#12679).DefWindowProc
Given that winit doesn't utilize the return value fromDefWindowProc
forWM_NCHITTEST
, we can bypass invoking DefWindowsProc for this message, thereby substantially boosting performance for high polling rate mice.Edit: This breaks some behaviours like mouse capture. Additional fixes needed.
changelog
module if knowledge of this change could be valuable to users