Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance cross-check workflow by adding target platforms and updating job names #1369

Merged
merged 3 commits into from
Nov 28, 2024
Merged

chore: enhance cross-check workflow by adding target platforms and updating job names #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f22bd17
chore: enhance cross-check workflow by adding target platforms and up…
simonsan Nov 26, 2024
e7005ea
chore(deps): add aws-lc-rs and aws-lc-sys to deny list due to build c…
simonsan Nov 27, 2024
b4fbc07
Merge branch 'main' into ci/new-targets
simonsan Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions .github/workflows/cross-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:

jobs:
cross-check:
name: Cross checking ${{ matrix.job.target }}
name: Cross checking ${{ matrix.job.target }} on ${{ matrix.rust }}
runs-on: ${{ matrix.job.os }}
strategy:
fail-fast: false
Expand All @@ -35,12 +35,11 @@ jobs:
target: x86_64-pc-windows-msvc
architecture: x86_64
use-cross: false
# FIXME: `aws-lc-sys` doesn't cross compile
# - os: windows-latest
# os-name: windows
# target: x86_64-pc-windows-gnu
# architecture: x86_64
# use-cross: false
- os: windows-latest
os-name: windows
target: x86_64-pc-windows-gnu
architecture: x86_64
use-cross: false
- os: macos-13
os-name: macos
target: x86_64-apple-darwin
Expand Down Expand Up @@ -76,18 +75,16 @@ jobs:
target: i686-unknown-linux-gnu
architecture: i686
use-cross: true
# FIXME: `aws-lc-sys` doesn't cross compile
# - os: ubuntu-latest
# os-name: netbsd
# target: x86_64-unknown-netbsd
# architecture: x86_64
# use-cross: true
# FIXME: `aws-lc-sys` doesn't cross compile
# - os: ubuntu-latest
# os-name: linux
# target: armv7-unknown-linux-gnueabihf
# architecture: armv7
# use-cross: true
- os: ubuntu-latest
os-name: netbsd
target: x86_64-unknown-netbsd
architecture: x86_64
use-cross: true
- os: ubuntu-latest
os-name: linux
target: armv7-unknown-linux-gnueabihf
architecture: armv7
use-cross: true

steps:
- name: Checkout repository
Expand Down
8 changes: 2 additions & 6 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,12 +183,8 @@ allow = [
]
# List of crates to deny
deny = [

# "[email protected]",
# { crate = "[email protected]", reason = "you can specify a reason it is banned" },
# Wrapper crates can optionally be specified to allow the crate when it
# is a direct dependency of the otherwise banned crate
# { crate = "[email protected]", wrappers = ["this-crate-directly-depends-on-ansi_term"] },
{ crate = "aws-lc-rs", reason = "this crate introduces exorbitant build effort and breaks cross-compilation" },
{ crate = "aws-lc-sys", reason = "this crate introduces exorbitant build effort and breaks cross-compilation" },
]

# List of features to allow/deny
Expand Down