rust-i18n-support: Use-after-free when setting the locale #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the report! I would like to give the maintainers some time to publish a fix, so that the advisory is actionable once it goes live. But if the maintainer doesn't respond, we can merge as-is to at least notify users of the crate. |
|
A fix was released in https://github.com/longbridgeapp/rust-i18n/releases/tag/v3.0.1. I changed the scope from |
Kijewski
changed the title
tarcieri
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0.0 introduced an
AtomicStrtype, that is used to store the current locale. It stores the locale as a raw pointer to anArc<String>. The locale can be read withAtomicStr::as_str().AtomicStr::as_str()does not increment the usage counter of theArc.If the locale is changed in one thread, another thread can have a stale -- possibly already freed -- reference to the stored string.