*ring* AES-CTR may panic when overflow checking is enabled. #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/ring-panic-overflow
branch
2 times, most recently
from
b62b4c3 to
bf27326
Compare
djc
reviewed
Mar 6, 2025
crates/ring/RUSTSEC-0000-0000.md
Outdated
Comment on lines
16
to
17
| `ring::aead::quic::HeaderProtectionKey::new_mask()` may panic when overflow | ||
| checking is enabled. |
There was a problem hiding this comment.
Maybe worth expanding slightly on when this happens? This gets one sentence while it seems much more risky than the AES-GCM usage, which you spend an entire paragraph on.
There was a problem hiding this comment.
Done. Check out the updated text, please.
briansmith
force-pushed
the
b/ring-panic-overflow
branch
from
bf27326 to
272f00e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.