Fix extra fixes / cleanups for object IDs #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some more conversions between ObjectId and another binary format which it might be useful to take. This also takes advantage of u128 formatting code, and uses it instead of manually formatting the three integers as one.
ASalvail
approved these changes
Aug 21, 2019
ASalvail
reviewed
Aug 21, 2019
| @@ -250,6 +286,29 @@ mod test { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Following @Dessix suggestion, it might be worth testing on wasm.
There was a problem hiding this comment.
I believe CI should be running all plain #[test] tests on WASM too as of a1d2162.
It doesn't seem to indicate what tests succeed, but a cursory test shows that locally, cargo web test --verbose --nodejs will fail if I insert a manual panic in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking over the changes made in #229, I realized that using
u128more could eliminate most/all of the manual formatting code forRawObjectId, and that a few more transitions which might be useful were missing.This:
TryFrom<u128>,Into<u128>,From<[u32; 3]>u128's code