Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address deprecation warnings #17

Closed
wants to merge 1 commit into from
Closed

Address deprecation warnings #17

wants to merge 1 commit into from

Conversation

kushaangupta
Copy link
Collaborator

Closes #16

@kushaangupta kushaangupta marked this pull request as draft September 14, 2024 02:29
@ryanharvey1
Copy link
Owner

Scipy wants us to use PyWavelets for morlet instead of scipy.signal.morlet. We can switch and add to requirements.

@kushaangupta
Copy link
Collaborator Author

I think the biggest problem for deprecation warnings comes from the nelpy. Maybe we should address that too in your fork

@ryanharvey1
Copy link
Owner

I think the biggest problem for deprecation warnings comes from the nelpy. Maybe we should address that too in your fork

Working on this now.

@ryanharvey1
Copy link
Owner

What's the current state of this PR?

@kushaangupta
Copy link
Collaborator Author

kushaangupta commented Nov 22, 2024 •
edited
Loading

Stale, the number of warnings has reduced. I think you addressed the most in nelpy. Maybe we address the final few and merge it

@kushaangupta kushaangupta force-pushed the main branch 2 times, most recently from a06e831 to 988f774 Compare November 26, 2024 23:50
@ryanharvey1
Copy link
Owner

Scipy wants us to use PyWavelets for morlet instead of scipy.signal.morlet. We can switch and add to requirements.

This represents the vast majority of warnings because the test is calling it 4000 something times.

@ryanharvey1 ryanharvey1 mentioned this pull request Dec 3, 2024
Merged
@ryanharvey1 ryanharvey1 closed this Dec 6, 2024
@ryanharvey1 ryanharvey1 deleted the fix-deprecation-warnings branch December 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deprecation warnings
2 participants
@kushaangupta @ryanharvey1